tektoncd/pipeline

feat(tracing): add spans for When Expression evaluation

Aperta

#9782 aperta il 16 apr 2026

 (2 commenti) (0 reazioni) (1 assegnatario)Go (1943 fork)auto 404
good first issuekind/feature

Metriche repository

Star
 (9013 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Feature request

Add OpenTelemetry spans to the When Expression evaluation path. CEL compilation/evaluation and Input/Operator/Values matching are currently invisible in traces, making it impossible to debug why tasks were skipped.

Use case

When a PipelineRun skips tasks due to When Expressions, the trace shows the parent reconcile span but gives no visibility into which expression evaluated to false or how long CEL compilation took.

Implementation hints

Key functions to instrument:

  1. pkg/reconciler/pipelinerun/pipelinerun.go:746EvaluateCEL() call for DAG tasks (inside loop)
  2. pkg/reconciler/pipelinerun/pipelinerun.go:965EvaluateCEL() call for finally tasks
  3. pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go:104EvaluateCEL() function itself — CEL env creation, compilation, evaluation
  4. pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go:488skipBecauseWhenExpressionsEvaluatedToFalse()
  5. pkg/apis/pipeline/v1/when_types.go:129AllowsExecution()

Span attributes to add: expression text, result (true/false), skip reason.

Parent spans exist: reconcile and runNextSchedulableTask are already spanned.

Part of umbrella: #9701

good first issue — focused scope, 2-3 functions, clear parent spans.

Guida contributor