Separate `-dump-clang-diagnostics` into two features.

(4 commenti) (0 reazioni) (1 assegnatario)Swift (10.719 fork)batch import

clang importergood first issue

Metriche repository

Star: (69.989 stelle)
Metriche merge PR: (Merge medio 8g 17h) (510 PR mergiate in 30 g)

Descrizione

Motivation

-dump-clang-diagnostics currently does two somewhat orthogonal things:

emits ad-hoc "remarks" on things ClangImporter is doing to stderr
emits clang diagnostics through both clang's and swift's diagnostic engine

Proposed solution

We should extract 1) into actual remarks, and enable them with -Rclang-importer (or whatever option https://github.com/swiftlang/swift/pull/87726 ends up adding).

Alternatives considered

-dump-clang-diagnostics may be left with just 2), or also enabling -Rclang-importer by default to keep the same behavior. I personally lean towards the former to avoid tangling orthogonal concepts, but I don't have a strong opinion.

Additional information

No response

Guida contributor

Direzione di ricerca: Studia l'implementazione di dump clang diagnostics nel compilatore Swift, in particolare in ClangImporter, per capire come attualmente emette remark e diagnostiche clang. Guarda la PR #87726 per il contesto sull'opzione Rclang importer. Proponi poi una patch per separare le due funzionalità convertendo i remark ad hoc in remark propri attivati da Rclang importer.
Tech stack: swift
Dominio: tooling
Tipo issue: Funzionalità
Difficoltà: 3
Tempo stimato: 1-2 giorni
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: Git
Adatta ai principianti: 50