swiftlang/swift

[SR-15176] Fixit for `override func` that should be `override var`

Open

#57.499 aperta il 9 set 2021

Vedi su GitHub
 (31 commenti) (0 reazioni) (1 assegnatario)Swift (10.719 fork)batch import
compilerdiagnostics qualityfix-itsgood first issueimprovementinheritanceoverrideswift 5.9

Metriche repository

Star
 (69.989 star)
Metriche merge PR
 (Merge medio 8g 17h) (510 PR mergiate in 30 g)

Descrizione

Previous ID SR-15176
Radar rdar://28337871
Original Reporter @CodaFi
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, DiagnosticsQoI, StarterBug
Assignee jiaren wang (JIRA)
Priority Medium

md5: b17661d61829d04b65f822d78b07388a

Issue Description:

Consider

class C {
  var canBecomeFirstResponder: Bool

  init() {}
}

class D: C {
    override func canBecomeFirstResponder() -> Bool {
    }
}

We should add a special case to diagnoseGeneralOverrideFailure that tries to see if it can correct no-args FuncDecls to VarDecls and vice-versa.

Guida contributor