swiftlang/swift

[SR-8252] Consolidate and Fix -debug-crash-* Flags

Open

#50.784 aperta il 13 lug 2018

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)Swift (10.719 fork)batch import
compilergood first issueimprovement

Metriche repository

Star
 (69.989 star)
Metriche merge PR
 (Merge medio 8g 17h) (510 PR mergiate in 30 g)

Descrizione

Previous ID SR-8252
Radar None
Original Reporter @CodaFi
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: 85fb82c2ea0303f5308473609b79bde5

Issue Description:

Currently, Swift has -debug-crash-immediately and -debug-crash-after-parse and -debug-assert-after-parse. The problem is twofold:

1) -debug-assert-after-parse understands the old hat meaning of "-parse" which used to mean "parse and type check". Now that the compiler understands these are distinct actions, this flag is misnamed.

2) The more useful distinction is crashing immediately versus crashing after a particular phase.

We should generalize -debug-assert and -debug-crash to mean "assert after the current frontend action finishes" or "crash after the current frontend action finishes" respectively. -debug-crash-immediately should still be retained because there needs to be a way to crash argument parsing.

Guida contributor