swiftlang/swift

[SR-7113] `try` on closures needs a clearer error message

Open

#49.661 aperta il 3 mar 2018

Vedi su GitHub
 (18 commenti) (0 reazioni) (0 assegnatari)Swift (10.719 fork)batch import
bugcompilerdiagnostics qualitygood first issue

Metriche repository

Star
 (69.989 star)
Metriche merge PR
 (Merge medio 8g 17h) (510 PR mergiate in 30 g)

Descrizione

Previous ID SR-7113
Radar None
Original Reporter designatednerd (JIRA User)
Type Bug

Attachment: Download

Xcode Version 9.2 (9C40b)

OS X Version 10.12.6 (16G1212)

swift --version output:

Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2)

Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee None
Priority Medium

md5: 0de4d3bda4791cbb582db3d2e00a5ef2

Issue Description:

When trying to add a try to a closure, the warning received is confusing if there is something within the closure which also needs a try. See attached screenshot for an example.

Per @jckarter, this is something which probably needs a clearer message: https://twitter.com/jckarter/status/969774890373996544

My personal suggestion for a message would be "try outside of a closure does not affect the code within the closure", but feel free to bikeshed that as much as you'd like.

Guida contributor