swiftlang/swift

[SR-3316] "Script mode" globals have internal visibility and can be accessed before initialization from other files

Aperta

#45.904 aperta il 2 dic 2016

 (1 commento) (0 reazioni) (1 assegnatario)Swift (10.719 fork)batch import
access controlcompilergood first issuescript modeswift evolution proposal needed

Metriche repository

Star
 (69.989 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Previous ID SR-3316
Radar None
Original Reporter @jckarter
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterProposal
Assignee None
Priority Medium

md5: e092a51eda538e02ab484391d0b1b1a5

Issue Description:

Variables declared in a script default to internal visibility, like other global declarations, but this is problematic, because semantically they behave more like local variables. Another file can access the global before its initializer has even run:

// main.swift
class C {}
var x: C
foo()
x = C()
// foo.swift
func foo() {
  print(x) // loads garbage from `x` from main.swift
}

In a future version of Swift, script globals should be changed to be private by default. We could possibly also allow a script global to be declared with explicit access control, which would make it visible to other files but would also have to make the variable behave more like a library global, with a dispatch_once-d initializer, e.g.:

// main.swift
var x = 42 // private, eagerly initialized
private var y = 17 // private, initialized on demand
internal var z = 38 // internal, initialized on demand

Guida contributor