swift-server/swift-service-lifecycle

Provide a `CancelOnGracefulShutdownService`

Aperta

#163 aperta il 31 ott 2023

 (3 commenti) (0 reazioni) (0 assegnatari)Swift (48 fork)auto 404
good first issue

Metriche repository

Star
 (528 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

If an adopter already has a reference type that implements a run() method it is currently impossible to support ServiceLifecycle, even though the implementation works easily:

extension MyExistingService: Service {}

The reason for this is, that ServiceLifecycle uses gracefulShutdown to signal shutdown instead of Task cancellation. That is the correct call. However it is impossible to add gracefulShutdown support to object that already expose a run() method. That's why im proposing that ServiceLifecycle offers a CancelOnGracefulShutdownService<Underlying: Service>.

Guida contributor