swift codegen does not support query parameters on POST
#1564 aperta il 12 nov 2015
Metriche repository
- Star
- (12.701 star)
- Metriche merge PR
- (Nessuna PR mergiata in 30 g)
Descrizione
POST methods with query parameter types map to Alamofire.ParameterEncoding.URL which means they are sent in the body of the request as application/x-www-form-urlencoded.
I need to support POST methods with query parameter types that map to Alamofire.ParameterEncoding.URLEncodedInURL. The generated code does not make it easy to support this due to its use of a boolean flag isBody, rather than an enumeration.
The following line in AlamofireImplementations.swift within the execute method is the issue:
let encoding = isBody ? Alamofire.ParameterEncoding.JSON : Alamofire.ParameterEncoding.URL
I believe the solution would be to refactor the isBody variable away in favor of an explicit ParameterEncoding type enum. This would make it easy to override the encoding behavior at the individual method level.