sugarlabs/musicblocks

Custom Pitch block's pie menu is reversed, no rotation, and no pitch preview

Aperta

#2255 aperta il 11 mag 2020

 (33 commenti) (0 reazioni) (0 assegnatari)JavaScript (1678 fork)auto 404
Good first issuePriority-Minor

Metriche repository

Star
 (854 stelle)
Metriche merge PR
 (Merge medio 9g 3h) (182 PR mergiate in 30 g)

Descrizione

Flipping the octave in the custom pitch pie menu works the opposite of how one would expect.

Right now, you must go down in pitch in order to tick the octave up.

My test was done this way:

  • Open Temperament Widget
  • Click on the pitches to go down in pitch (C, A#, G, F, D# --> C)
  • The octave will go up, not down

or

  • Click on the pitches to go up in pitch (C, D#, F, G, A# --> C)
  • The octave will go down, not up

Screenshot Screenshot at 2020-05-11 10:02:24 temperament pie menu

I do not know if it is at all related, but a "electronic synth null null undefined" error/warning keeps popping up:

0 A♯(+12.63)(+0)7 0.125 electronic synth null null undefined
synthutils.js:1198 
[3644.132531921655]
synthutils.js:1402 0 A♯(+12.63)(+0)7 0.125 electronic synth null null undefined
synthutils.js:1198 
[3644.132531921655]
synthutils.js:1402 0 G(+25.26)(+0)7 0.125 electronic synth null null undefined
synthutils.js:1198 
[3172.401628390128]
synthutils.js:1402 0 F(-25.26)(+0)7 0.125 electronic synth null null undefined
synthutils.js:1198 
[2761.736024596567]
synthutils.js:1402 0 D♯(-12.63)(+0)7 0.125 electronic synth null null undefined
synthutils.js:1198 
[2404.2308518877403]
synthutils.js:1402 0 C(+0)(+0)7 0.125 electronic synth null null undefined
synthutils.js:1198 
[2093.0045224047926]
synthutils.js:1402 0 A♯(+12.63)(+0)8 0.125 electronic synth null null undefined
synthutils.js:1198 
[7288.26506384331]
synthutils.js:1402 0 G(+25.26)(+0)8 0.125 electronic synth null null undefined
synthutils.js:1198 
[6344.803256780256]
synthutils.js:1402 0 F(-25.26)(+0)8 0.125 electronic synth null null undefined
synthutils.js:1198 
[5523.472049193134]
synthutils.js:1402 0 D♯(-12.63)(+0)8 0.125 electronic synth null null undefined
synthutils.js:1198 
[4808.461703775481]
synthutils.js:1402 0 G(+25.26)(+0)8 0.125 electronic synth null null undefined
synthutils.js:1198 
[6344.803256780256]

Guida contributor