styleguidist/react-styleguidist

Allow showing warnings from underlying libraries

Open

#1570 aperta il 27 mar 2020

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)TypeScript (1416 fork)github user discovery
bughelp wanted

Metriche repository

Star
 (11.091 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

The problem

Recently our project was bitten by a known issue in styled-components (https://github.com/styled-components/styled-components/issues/2962#issuecomment-576807762) that caused our production build to lose all its styling.

The issue itself had to do with the fact that we used an @import to refer to a font and currently that's not supported when building. styled-components gives a build-time warning so developers know to fix this. Personally I would have thrown an Error as it's a fatal issue but they went this way.

Unfortunately, the way our styleguidist is configured, we weren't able to see the warning in time. I tried configuring webpack to emit more but it didn't seem to make a difference.

Proposed solution

Ideally there should be a way to show webpack warnings in styleguidist output to catch these kind of issues.

Alternative solutions

Additional context

Guida contributor