strawberry-graphql/strawberry-django

LSP: warn on `fields="__all__"` and add code action to expose all fields

Aperta

#558 aperta il 14 giu 2024

 (0 commenti) (0 reazioni) (0 assegnatari)Python (152 fork)auto 404
enhancementhelp wanted

Metriche repository

Star
 (496 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

We don't have an LSP for Strawberry Django, but in case we add one I think this feature would be neat to have.

We allow to use fields="__all__", which might lead to security issues, so the LSP could warn when using that, and also provide a code action that does what __all__ does, but with code

From this:

@strawberry.django.type(models.Flyer, fields="__all__")
class Flyer:
    ...

To this:

@strawberry.django.type(models.Flyer)
class Flyer:
    id: auto
    title: auto

We could also add code action to expose additional fields :)

Guida contributor