stereobooster/react-snap

Crawl only html documents

Open

#339 aperta il 28 feb 2019

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)JavaScript (403 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (4982 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Feature Request

Is your feature request related to a problem? Please describe. Puppeteer does not handle PDF files. react-snap will crawl to them if links exist and the process will crash. There doesn't seem to be a way to ignore this.

Describe the solution you'd like I'd like the ability to be able to specify files/paths/globs to ignore as an option.

Describe alternatives you've considered I've looked at other snapshot libraries but prefer this one. I've looked at whether it's possible to pass an argument to puppeteer to handle this but it doesn't seem to be.

Teachability, Documentation, Adoption, Migration Strategy I'd imagine an option in package.json, like:

ignore: ["**.pdf"]

Guida contributor