spring-cloud/spring-cloud-netflix

RequestSpecificRetryHandler retries same server for SERVER_THROTTLED

Open

Aperta il 27 dic 2017

Vedi su GitHub
 (10 commenti) (0 reazioni) (0 assegnatari)Java (4805 star) (2433 fork)batch import
help wanted

Descrizione

Netflix's RequestSpecificRetryHandler allows to retry on same server for SERVER_THROTTLED error.

When the okToRetryOnAllErrors property is true, the retry handler allows to retry on the same server unconditionally without taking into account the actual error. This is useless when the server responded with SERVER_THROTTLED.

It looks like the if statement at https://github.com/Netflix/ribbon/blob/master/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java#L58-L65 should be considered first before the other conditions.

I doubt Netflix is willing to change this behavior but we could override it in SpringCloud. What do you think ?

Guida contributor

Tech stack
java
Dominio
backendperformance
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaUnderstanding of Ribbon retry handlersSpring Cloud Netflix basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
The issue identifies a bug in RequestSpecificRetryHandler where the okToRetryOnAllErrors flag overrides the specific check for SERVER THROTTLED, causing retries on the same server. The proposed fix is to reorder the if statement at lines 58-65 in ribbon core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java to check SERVER THROTTLED first. Examine how Spring Cloud Netflix customizes retry logic, possibly via a custom retry handler, and review the issue comments for maintainer consensus.