spring-cloud/spring-cloud-netflix

Update Eureka client status URL based on SSL configuration

Open

Aperta il 7 apr 2017

Vedi su GitHub
 (12 commenti) (0 reazioni) (0 assegnatari)Java (4805 star) (2433 fork)batch import
enhancementhelp wanted

Descrizione

Hi,

If I use secure-port in my configuration and I don't specify the management.port, then spring cloud does not change my eureka statusPageUrl and other url's to https.
The if condition at line number 114 in EurekaClientAutConfiguraiton.java (spring-cloud-netflix-eureka-client: 1.2.6 release) prevents it from changing the scheme and it lets netflix configure the url . In netflix's InstanceInfo.java there is no check for secure port and the protocol is hardcoded to http.

I am not sure where to raise this issue, but since I am using spring-cloud-netflix I am putting this here

Guida contributor

Tech stack
java
Dominio
backendcloud
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Understanding of Spring Cloud Netflix Eureka client configurationKnowledge of Java and Spring Boot
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Examine the condition at line 114 in EurekaClientAutoConfiguration.java that prevents updating the statusPageUrl scheme to HTTPS when secure port is set but management.port is not specified. Also review InstanceInfo.java from Netflix's Eureka client where the protocol is hardcoded to http. Consider modifying the condition to check for secure port presence, or change the default behavior to respect secure port. Test with secure port configuration and verify that status and health URLs use HTTPS.