spring-cloud/spring-cloud-gateway
Vedi su GitHubIdentical Routes are not considered equal: AsyncPredicate does not override equals()
Open
#3236 aperta il 25 gen 2024
bughelp wanted
Metriche repository
- Star
- (4284 star)
- Metriche merge PR
- (Merge medio 1g 21h) (18 PR mergiate in 30 g)
Descrizione
Two logically equal Routes are not programmatically equal since Route's equals() compares predicates, and the AsyncPredicate class does not override equals() (hence you get a simple reference comparison). Here's a test that reproduces the issue:
class RouteEqualityTest {
@Test
void testTwoIdenticalRouteAreEqual() {
assertThat(getRouteBuilderStub().build()).isEqualTo(getRouteBuilderStub().build());
}
private Route.AsyncBuilder getRouteBuilderStub() {
return Route.async()
.id("123")
.uri("https://example.com")
.predicate(exchange -> exchange.getRequest()
.getPath()
.value()
.equals("/test-path"));
}
}