spiffe/spire
Fix the "expiring" and "outdated" metrics emitted during entry sync to be accurate across the whole cache
Aperta
#2437 aperta il 3 ago 2021
help wantedpriority/backlog
Metriche repository
- Star
- (2443 stelle)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
// TODO: this values are not real, we may remove
if expiring > 0 {
telemetry_agent.AddCacheManagerExpiredSVIDsSample(m.c.Metrics, float32(expiring))
m.c.Log.WithField(telemetry.ExpiringSVIDs, expiring).Debug("Updating expiring SVIDs in cache")
}
if outdated > 0 {
telemetry_agent.AddCacheManagerOutdatedSVIDsSample(m.c.Metrics, float32(outdated))
m.c.Log.WithField(telemetry.OutdatedSVIDs, outdated).Debug("Updating SVIDs with outdated attributes in cache")
}
It's not clear what is meant by "[these] values are not real" and why (I'm assuming) the metric blocks may be removed?
- If this logic or similar may be removed, let's go ahead and remove it for this issue
- If removal can't be done yet, let's update that comment to be more specific, and add a github issue number tracking removal
- If the removal can't or is not foreseen as ever removable, let's get rid of the comment