sktime/sktime

[ENH] complete `scikit-base`-refactor of `sktime` test framework

Aperta

#10.647 aperta il 25 lug 2026

 (5 commenti) (0 reazioni) (1 assegnatario)Python (1192 fork)batch import
enhancementgood first issuemodule:tests

Metriche repository

Star
 (7162 stelle)
Metriche merge PR
 (Merge medio 26g 10h) (86 PR mergiate in 30 g)

Descrizione

In 2023, the test framework of sktime was moved to scikit-base, however, one refactor step was not carried out.

This is the replacement of the TestAllObjects and TestAllEstimators test classes by the scikit-base class.

The problem that prevented doing this is the renaming of estimator_class and estimator_instance fixture to object_class and object_instance in scikit-base, which requires to rename these parameters throughout in sktime.

A previous pull request attempting this is here: https://github.com/sktime/sktime/pull/4283 - however, this does not rename the fixtures throughout the sktime code base.

The skpro package has an example where the test classes directly are obtained from scikit-base, and can serve as a template for the target state.

Guida contributor