sindresorhus/eslint-plugin-unicorn
`prefer-dom-node-append`: Property 'append' does not exist on type 'ChildNode'.
Chiusa
#2474 aperta il 8 ott 2024
docshelp wantedtypes
Metriche repository
- Star
- (5022 stelle)
- Metriche merge PR
- (Merge medio 4h 30m) (26 PR mergiate in 30 g)
Descrizione
Description
Code using appendChild on a Node should not be autofixed to use append. I think this can be improved by using type information and only raising an issue when (or at the very least not autofixing unless) it is known to be an Element.
This relates to https://github.com/sindresorhus/eslint-plugin-unicorn/issues/347
Fail
These are currently working fine and should still work
const foo = (element: Element, htmlElement: HTMLElement) => {
element.appendChild(node)
htmlElement.appendChild(node)
}
document.getElementsByName("name")[0]?.appendChild(document.createTextNode("foo"))
Pass
const foo = (node: Node, childNode: ChildNode, untyped, element: Element) => {
node.appendChild(node) // Current false positive
childNode.appendChild(node) // Current false positive
childNode.appendChild(node) // Current false positive
element.append(node)
}
document.body.childNodes[0]?.appendChild(document.createTextNode("foo")) // Current false positive
Additional Info
These examples are oversimplified just to get the right type.