serverless-nextjs/serverless-next.js

Add CloudFront Standard Logging Support

Open

Aperta il 23 ago 2021

Vedi su GitHub
 (2 commenti) (3 reazioni) (0 assegnatari)TypeScript (3998 star) (447 fork)batch import
enhancementgood first issue

Descrizione

Is your feature request related to a problem? Please describe. To aid with troubleshooting and auditing I'd like the ability to be able to enable and configure CloudFront Standard Logging from within the serverless.yml configuration file.

Describe the solution you'd like The following attributes to be supported under the CloudFront

logging:
  bucket: 'myawslogbucket.s3.amazonaws.com.'
  includeCookies: false
  prefix: 'myfolder/'

For example

WebApp:
  component: '@sls-next/serverless-component@latest'
  inputs:
    cloudfront:
      logging:
        bucket: 'myawslogbucket.s3.amazonaws.com.'
        includeCookies: false
        prefix: 'myfolder/'

These attributes should as per the CloudFormation documentation here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-logging.html

Describe alternatives you've considered None

Guida contributor

Tech stack
typescriptnextjsaws
Dominio
infrastructurecloudbackend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Familiarity with serverless.ymlUnderstanding of CloudFront loggingBasic TypeScript
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
Locate the CloudFront distribution configuration in the component's source code, likely in src/component.ts or src/resources/cloudfront.ts. Examine how existing properties like 'defaultRootObject' or 'priceClass' are defined and integrated into the CloudFormation template. Add a new 'logging' property that maps to the AWS::CloudFront::Distribution Logging property. Ensure the property accepts 'bucket', 'includeCookies', and 'prefix' fields. Validate the configuration against the CloudFormation documentation. No linked PRs or comments to reference; the implementation should follow existing patterns.