[Refactor] Refactor Language keyboards objects to follow SOLID principles · scribe-org/Scribe-iOS#377

2023-10-31T13:38:35.000Z

### Terms - [X] I have searched [open and closed feature requests](https://github.com/scribe-org/Scribe-iOS/issues?q=is%3Aissue+label%3Afeature) - [X] I agree to follow Scribe-iOS' [Code of Conduct](https://github.com/scribe-org/Scribe-iOS/blob/main/.github/CODE_OF_CONDUCT.md) ### Description The `LanguageKeyboards` group contains sub-groups for each supported languages by **Scribe**. Those sub-groups contains files that exposes app level functions and enums that are all similar but are not following any strict protocol. The end goals here would be the following: - Extract all the keyboards related constants into a dedicated package / framework within a common workspace file - Expose dedicated protocols for language keyboards that exposes the required functions and constants - Refactor all language keyboards to adhere to the newly created protocols - Refactor the `Info.plist` to move the constants into a single localised file and create custom `Build Settings` to exposes the constants to a single `Info.plist` file (or find another solution) - Extract all the common keys between keyboard to constants to avoid manually hardcoded strings - Add unit tests to ensure each language keyboard is working has expected ### Contribution _No response_

(0 commenti) (2 reazioni) (0 assegnatari)Swift (106 fork)auto 404

help wantedrefactor

Metriche repository

Star: (167 star)
Metriche merge PR: (Metriche PR in attesa)

Descrizione

Terms

I have searched open and closed feature requests
I agree to follow Scribe-iOS' Code of Conduct

Description

The LanguageKeyboards group contains sub-groups for each supported languages by Scribe.

Those sub-groups contains files that exposes app level functions and enums that are all similar but are not following any strict protocol.

The end goals here would be the following:

Extract all the keyboards related constants into a dedicated package / framework within a common workspace file
Expose dedicated protocols for language keyboards that exposes the required functions and constants
Refactor all language keyboards to adhere to the newly created protocols
Refactor the Info.plist to move the constants into a single localised file and create custom Build Settings to exposes the constants to a single Info.plist file (or find another solution)
Extract all the common keys between keyboard to constants to avoid manually hardcoded strings
Add unit tests to ensure each language keyboard is working has expected

Contribution

No response

Guida contributor

Direzione di ricerca: Inizia definendo un protocollo per le tastiere linguistiche (ad esempio, LanguageKeyboardProtocol) con proprietà e metodi richiesti. Quindi rifattorizza una tastiera linguistica (ad esempio, tedesco) per conformarsi al protocollo, usandola come modello per le altre. Estrai le costanti comuni in un file dedicato. Considera la creazione di un pacchetto SPM per le costanti della tastiera.
Tech stack: swift
Dominio: mobile
Tipo issue: Refactoring
Difficoltà: 3
Tempo stimato: 1-2 giorni
Stato attività: Nuova
Chiarezza: Abbastanza chiara
Prerequisiti: SwiftiOS developmentprotocol oriented programming
Adatta ai principianti: 30