schickling/chromeless

Listening to instance events

Open

Aperta il 22 ago 2017

Vedi su GitHub
 (1 commento) (3 reazioni) (0 assegnatari)TypeScript (13.240 star) (606 fork)batch import
APIfeaturehelp wanted

Descrizione

With nightmare.js it is possible to add an event listener, for example:

function onResponseDetails(event, status, newURL, originalURL, httpResponseCode, requestMethod, referrer, headers, resourceType) {
    if (httpResponseCode === 200) {
        if (resourceType === 'stylesheet') { stylesheets.push(newURL); }
        if (resourceType === 'image') { images.push(newURL);}
    }
  }

nightmare.on('did-get-response-details', onResponseDetails)

I think it's actually a electron feature https://electron.atom.io/docs/api/web-contents/#instance-events.

Anyway, I humbly request similar functionality to be added to chromeless. (Perhaps there is a way already?)

Thank you for your time!

Guida contributor

Tech stack
typescriptelectron
Dominio
backend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Basic knowledge of Electron eventsFamiliarity with chromeless API
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Investigate Electron's web contents instance events (https://electron.atom.io/docs/api/web contents/#instance events) and study how nightmare.js implements its .on() method. Review chromeless source code for existing event handling patterns and propose a minimal implementation that exposes a similar .on() method on chromeless instances. Ensure consistency with the existing API and consider adding tests.