schickling/chromeless

Ability to change image type and quality on screenshot

Open

Aperta il 21 ago 2017

Vedi su GitHub
 (0 commenti) (8 reazioni) (0 assegnatari)TypeScript (13.240 star) (606 fork)batch import
APIfeaturehelp wanted

Descrizione

I wanted to use jpeg to capture screenshots with lower quality so I can render the screenshots much faster (which has typically been the case when using other tools like phantomJS).

The current API doesn't have support for these customization when generating a screenshot. Capture screenshot method supports image format and quality (as well as some other options): https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-captureScreenshot

It would be great if the chromeless API had support for this. Seems like PDF options are already supported and is just a passthrough to the CDT: https://github.com/graphcool/chromeless/blob/master/src/api.ts#L234

Would be great to expose something similar for captureScreenshot

Thanks!

Guida contributor

Tech stack
typescriptnodejs
Dominio
testingtooling
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
TypeScriptNode.jschromeless APIChrome DevTools Protocol
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
Examine src/api.ts line 234 for the PDF passthrough pattern and implement similar parameter forwarding for the captureScreenshot method. Refer to the Chrome DevTools Protocol documentation for captureScreenshot parameters. Ensure new options are correctly typed and passed to the underlying CDP call.