A-lintL-correctnessL-unnecessaryT-middlegood first issue
Metriche repository
- Star
- (10.406 star)
- Metriche merge PR
- (Merge medio 19g 22h) (113 PR mergiate in 30 g)
Descrizione
(x + n + y) % n or (x + n + y) / n can simply be replaced by (x + y) % n or (x + y) / n + 1
this isn't true for the following computations on unsigned integers:
(x + n - y) % n or (x + n - y) / n
as they might go negative due to the subtraction. For explicitly evading INT_MAX issues, this lint will cause false positives, but that could be evaded by not linting if INT_MAX is mentioned somewhere near the operation.
most likely, whenever this lint triggers, it is a bug in the equation, so the suggestion doesn't fix the underlying issue, but it will raise awareness of it.