restify/node-restify

maintenance branch releases accidentally blow away "latest" npm dist-tag

Aperta

#1392 aperta il 29 giu 2017

 (8 commenti) (0 reazioni) (1 assegnatario)JavaScript (983 fork)batch import
CriticalFeatureHelp Wanted

Metriche repository

Star
 (10.695 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Currently on the 4.x branch (now a maintenance branch since 5.0.0 has been released), the make cutarelease target is used to tag and publish a new release. npm publish however will implicitly assign the 'latest' dist tag to this releae. We don't want that for 4.x, because 5.x releases should stay as the "latest".

Proposal: Use npm publish --tag=latest-4. Explicitly using a tag gets npm publish to not implicitly use 'latest'. I'm copying npm's own "latest-$majorver" pattern here:

$ npm info npm dist-tags

{ latest: '5.0.4',
  next: '5.0.4',
  'latest-2': '2.15.12',
  'next-2': '2.15.12',
  'latest-1': '1.4.29',
  lts: '2.15.11',
  'latest-3': '3.10.10',
  'next-3': '3.10.10',
  'latest-4': '4.6.1',
  'next-4': '4.6.1',
  'latest-5': '5.0.4',
  'next-5': '5.0.4',
  'v5.0-next': '5.0.4' }

@retrohacker Sound good?

Guida contributor