`suggest-commit-title-limit` further improvements to PR titles
#7760 aperta il 27 ago 2024
Metriche repository
- Star
- (22.918 star)
- Metriche merge PR
- (Merge medio 1g 18h) (44 PR mergiate in 30 g)
Descrizione
Description
Continuing from:
We should apply two further improvements to the PR title:
- use monospace font
- limit width of the field
We already do this for the commit title field and they help the user see how close they are to the limit. Currently you just have to guess until suddenly the field turns red.
Also:
- Disable the feature after PR merge (not closure)
The limit exclusively exists to facilitate merging, but that’s not really a problem after the merge commit has been created.
And:
- Disable limit if we detect the user will not use a squash commit
Again, the limit does not apply there, so there’s no reason to do limit the user. Unfortunately I don’t think this is easily possible because it depends on the mergeability box, which only exists for people who can merge.