recloudstream/cloudstream

Improve delayed updater triggering method

Open

#1282 aperta il 16 ago 2024

Vedi su GitHub
 (2 commenti) (1 reazione) (0 assegnatari)Kotlin (877 fork)batch import
enhancementgood first issue

Metriche repository

Star
 (9642 star)
Metriche merge PR
 (Merge medio 4g 8h) (49 PR mergiate in 30 g)

Descrizione

Describe your suggested feature

Currently actually updating is done in onPause() in MainActivity, this causes inconsistent and unexpected triggering behavior. I suggest we move this to onDestroy() And add a persistent notification that says something like "Update now" on mobile, and auto stop app when you click update on TV. This is because onPause() is also triggered when you enter PiP mode or switch activities such as going to "Manage Accounts". I understand the reason for waiting is for user choice but the current implementation I don't think actually indicates "user choice" as if you forget about it or something and go home you inadvertently start the update which force stops the app. To me, this is bad behaviour.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Guida contributor