reactjs/react-modal

How do I close Modal on right click in overlay?

Open

Aperta il 15 nov 2020

Vedi su GitHub
 (6 commenti) (0 reazioni) (1 assegnatario)JavaScript (7294 star) (828 fork)batch import
easyfeaturehelp wanted

Descrizione

Summary:

I wish to close the modal on secondary click (right mouse click). This works in your codepen demo for v.1.6.2: https://codepen.io/claydiffrient/pen/ZBmyKz?editors=1111 But not in my own demo with v3.3.2, see here: https://codepen.io/CharlotteA/pen/PozLwNw?editors=1111

Am I missing a new prop to handle this?

Expected behavior:

Close on right-click: https://codepen.io/claydiffrient/pen/ZBmyKz?editors=1111

Link to example of issue:

Not closing on right-click: https://codepen.io/CharlotteA/pen/PozLwNw?editors=1111

Any help very much appreciated!  🤓

Guida contributor

Tech stack
reactjavascriptcss
Dominio
frontendaccessibility
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
React basicsreact modal library
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Investigate the current EventManager.js in react modal to understand how click events are handled. Review the change from v1.6.2 to v3.3.2 that removed the right click close behavior. Check the GitHub issues and PRs for any related discussion on right click handling. Consider adding a prop like 'closeOnRightClick' or re enabling the default behavior.