reactjs/react-modal

Focus escapes modal when radio buttons in modal

Open

Aperta il 29 mar 2018

Vedi su GitHub
 (8 commenti) (11 reazioni) (0 assegnatari)JavaScript (7294 star) (828 fork)batch import
accessibilitybugeasygood first issue

Descrizione

Summary:

When there are radio buttons in a modal, you can escape focus with shift-tab.

Steps to reproduce:

Steps are included in the test case below

Expected behavior:

You should not be able to escape the modal's focus

Link to example of issue:

https://codesandbox.io/s/my9vm34m68

Additional notes:

Not sure if it's related specifically to radio buttons, but that is what is causing the issue for me

Guida contributor

Tech stack
reactjavascript
Dominio
frontendaccessibility
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
React basicsFocus management in web appsUnderstanding of tab order
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
Investigate the focus trapping logic in the modal component, likely in files like 'src/components/Modal.js' or similar. The provided CodeSandbox (https://codesandbox.io/s/my9vm34m68) demonstrates the issue with Shift+Tab escaping when radio buttons are present. Review the focus management code, particularly how it handles the first and last focusable elements, and ensure radio buttons are properly included in the focus order. Consider using a focus trap library like 'focus trap' or adjusting the existing implementation to handle the radio button's group focus behavior.