rapidsai/cudf

Add unit tests for fixed point in quantiles

Open

#9469 aperta il 19 ott 2021

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)C++ (735 fork)batch import
buggood first issuelibcudftests

Metriche repository

Star
 (6000 star)
Metriche merge PR
 (Merge medio 17g 21h) (230 PR mergiate in 30 g)

Descrizione

Describe the bug Quantiles support fixed point columns. but it is not tested in unit tests (both gtest and pytest).

Expected behavior add unit tests for fixed_point in quantiles gtest

Additional context https://github.com/rapidsai/cudf/issues/9468 While adding FixedPointTypes to cudf::test::AllTypes, QUANTILES_TEST (Failed).

[ FAILED ] QuantileUnsupportedTypesTest/10.TestZeroElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestOneElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestMultipleElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestZeroElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestOneElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestMultipleElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>

6 FAILED TESTS

Guida contributor