rapidsai/cudf

[FEA] Clean up `type_to_name` and add `print_type` debug utility

Open

#17.376 aperta il 19 nov 2024

Vedi su GitHub
 (5 commenti) (1 reazione) (0 assegnatari)C++ (735 fork)batch import
feature requestgood first issuelibcudf

Metriche repository

Star
 (6000 star)
Metriche merge PR
 (Merge medio 17g 21h) (230 PR mergiate in 30 g)

Descrizione

Is your feature request related to a problem? Please describe. PR #17194 introduces a type_id to string utility located within the benchmark code.

@ttnghia identified that this could be a shared utility for both benchmarks and tests, as it could also be used to create a print_type utility for debugging purposes (see: https://github.com/rapidsai/cudf/pull/17194/files#r1849064965). @davidwendt highlighted that this feature is redundant and performs a similar function to type_to_name.

Describe the solution you'd like

  • Once #17194 is merged, replace stringify_type with type_to_name
  • Replace the type stringify logic in benchmarks/io/nvbench_helpers.hpp with type_to_name
  • Add a host-device print_type utility in cudf_test/print_utilities.cuh using type_to_name for debugging (Note that making it host-device is not mandatory, as type_to_name is currently host-only. However, enabling its use on both host and device, as required by print_type, would involve additional work, such as relocating it to a .cuh header and potentially modifying downstream usage.)

Guida contributor