qmk/qmk_firmware

[Bug] QMK doctor only checks /etc/udev/rules.d for udev rules.

Open

#9906 aperta il 1 ago 2020

Vedi su GitHub
 (3 commenti) (0 reazioni) (1 assegnatario)C (43.867 fork)batch import
bughelp wanted

Metriche repository

Star
 (20.368 star)
Metriche merge PR
 (Merge medio 20g 9h) (27 PR mergiate in 30 g)

Descrizione

The doctor command in qmk python library fails to find the correct rules in /usr/lib/udev/rules.d directory.

Describe the Bug

The doctor command in QMK python library only checks a hard coded /etc/udev/rules.d for udev rules. Which works fine if you put your rules there. But these rules can also be located in /usr/lib/udev/rules.d; and actually is the preferred location for linux package managers to drop their udev rules. I recently packaged the python client in archlinux; and also provided neccessary udev rules along with it. After switching to these rules, I noticed I was getting warnings from qmk doctor when I had the correct udev rules in place.

System Information

  • Keyboard: N/A
  • Operating system: Archlinux
  • AVR GCC version: 10.1.0
  • ARM GCC version: 10.1.0
  • QMK Firmware version: 0.9.46
  • Any keyboard related software installed?
    • Karabiner
    • Other:
    • AutoHotKey

Additional Context

I also implemented a quick fix; and issued the pull request #9907

Guida contributor

Direzione di ricerca
Esamina la PR #9907 per la correzione proposta e applica una logica simile per controllare /usr/lib/udev/rules.d oltre a /etc/udev/rules.d.
Tech stack
python
Dominio
backend
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Attiva
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
Python
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70