qmk/qmk_firmware

[Bug] Weak mods not cleared properly when using Layer Tap and quicky tapping shifted keycodes.

Open

#17.569 aperta il 5 lug 2022

Vedi su GitHub
 (14 commenti) (7 reazioni) (0 assegnatari)C (43.867 fork)batch import
bughelp wanted

Metriche repository

Star
 (20.368 star)
Metriche merge PR
 (Merge medio 20g 9h) (27 PR mergiate in 30 g)

Descrizione

Describe the Bug

Have LT(1, KC_SPACE), on layer one, have KC_COLN (shifted semicolon), and KC_LBRC (not shifted). If you hit LT, then the colon, and then any non-shifted key, it will be shifted.

Eg, this should produce: :] but will produce :}. Not every time, but if you do this fast enough, it will happen consistently.

I have tracked this down to the code change in #9941. However reverting this breaks a number of other pathways. Even partially reverting it (adding the clear weak mods to both sections).

it may be possible to fix the other features, as well, but.....

System Information

Keyboard: Moonlander, Charybdis, Ergodox EZ Revision (if applicable): N/A Operating system: MacOS, Windows qmk doctor output: Not relevant to this

Any keyboard related software installed?

  • AutoHotKey (Windows)
  • Karabiner (macOS)
  • Other:

Additional Context

Explicitly reverting the code change from #9941 fixes the issue. But breaks other features, such as caps words.

@IsaacElenbaas @getreuer a heads up

Guida contributor