qmk/qmk_firmware

[Bug] Retro Shift not working on Mod Tap keys

Open

#15.458 aperta il 12 dic 2021

Vedi su GitHub
 (8 commenti) (0 reazioni) (0 assegnatari)C (43.867 fork)batch import
bughelp wanted

Metriche repository

Star
 (20.368 star)
Metriche merge PR
 (Merge medio 20g 9h) (27 PR mergiate in 30 g)

Descrizione

Describe the Bug

Using Retro_Shift has no effect on my Mod Tap keys. Auto Shift is enabled and works for normal alpha keys. But when exceeding the AUTO_SHIFT_TIMEOUT on the Mod Tap keys without pressing an additional key, retro shift doesn't trigger.

System Information

  • Keyboard: Planck
    • Revision (if applicable): rev6_drop
  • Operating system: macOS 12.1
  • AVR GCC version: 8.4.0
  • ARM GCC version: 8.3.1
  • QMK Firmware version: 0.15.6
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

Retro Shift added in https://github.com/qmk/qmk_firmware/commit/d9393b86842b7ef143259b5f771ae7969f98cbb4

Relevant part of config.h:

// Tapping Term
#define TAPPING_TERM 300
#define TAPPING_TERM_PER_KEY

// Prevent normal rollover on alphas from accidentally triggering mods.
#define IGNORE_MOD_TAP_INTERRUPT

// Auto Shift
#define NO_AUTO_SHIFT_NUMERIC
#define NO_AUTO_SHIFT_SPECIAL
#define AUTO_SHIFT_REPEAT
#define AUTO_SHIFT_TIMEOUT TAPPING_TERM
#define AUTO_SHIFT_NO_SETUP
#define RETRO_SHIFT

Guida contributor