pytorch/ignite

`Timer`'s misleading behaviour when epoch completion time calculated

Open

Aperta il 11 ago 2021

Vedi su GitHub
 (7 commenti) (1 reazione) (1 assegnatario)Python (4313 star) (602 fork)batch import
HacktoberfestPyDataGlobalenhancementhelp wanted

Descrizione

When I tried calculating the time taken to complete a single epoch via Timer, the handlers attached to trainer before Timer were executed first, and thus their time also got recorded by the Timer too for a single epoch. Therefore the true time taken for epoch completion, provided by trainer.state.times, is less than what Timer calculated. This can be misleading. More clarification on how this actually works in the docs would be appreciated. Or the Timer's functionality can be enhanced to step before all other handlers attached to an event could also be helpful. Notebook to quickly verify this here.

Guida contributor

Tech stack
pythonpytorch
Dominio
machine learningdeveloper experience
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Familiarity with PyTorch Ignite event system
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Examine the Timer implementation in PyTorch Ignite, specifically how it hooks into events. The issue suggests that Timer should step before other handlers. Check the source code for the Timer class and its event registration. Consider whether a simple reordering of handler execution or a new event attribute is needed. The provided Colab notebook can be used to reproduce the issue.