pytorch/examples

imagenet benchmark measure elapsed time function issue

Open

Aperta il 23 mar 2020

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Python (21.634 star) (9429 fork)batch import
good first issue

Descrizione

Hi Pytorch team, I think the measure elaspsed time function is not right. Both trainning and validate function show the progress if i %args.print_freq == 0 in magenet/main.py . currently, the batch_time only measure one loop. I think the batch_time should measure args.print_freq loop elaspsed time.

     # measure elapsed time
     batch_time.update(time.time() - end)
     end = time.time()

     if i % args.print_freq == 0:
         progress.display(i)

Guida contributor

Tech stack
python
Dominio
machine learning
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic PythonPyTorch basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85
Direzione di ricerca
The issue is in imagenet/main.py. Currently, batch time.update is called every iteration, but it should average over args.print freq iterations. The fix involves moving the measurement to after the print freq loop or accumulating time over multiple iterations. Examine lines around batch time.update and the loop condition to implement the change.