pypa/pipx

parallel execution of pipx

Open

#1056 aperta il 13 set 2023

Vedi su GitHub
 (2 commenti) (4 reazioni) (0 assegnatari)Python (363 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (7844 star)
Metriche merge PR
 (Merge medio 5g 2h) (16 PR mergiate in 30 g)

Descrizione

Not sure if this is a bug or a feature request, I just wanted to note this here since I haven't seen a pertaining issue.

Describe the bug Executing pipx commands in parallel can result in unforeseen issues. I have noticed two main types of issues:

  1. pipx list fails if pipx install is ongoing due to missing metadata
  2. if shared libraries are outdated, any pipx command will trigger a shared libraries upgrade, which will cause concurrent commands to fail

How to reproduce

Scenario 1

import subprocess
from concurrent.futures import ThreadPoolExecutor
from typing import List

cmd = ["pipx", "list"]
cmd_list = [cmd] * 5 + ["pipx", "install", "pycowsay"]
with ThreadPoolExecutor() as executor:
    results: List[subprocess.CompletedProcess] = list(executor.map(subprocess.run, cmd_list))

print(results)

Scenario 2 as above, but remove the pipx install and ensure shared libraries are outdated, for example by running in a docker container with outdated libraries

Expected behavior Don't fail, but wait for the concurrent process to finish (debatable)

At the very least I'd expect pipx list not to fail with exit code 1 when a pipx install is ongoing

Guida contributor