provectus/kafka-ui

FE: Handle 504s properly

Open

Aperta il 1 ago 2023

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)Java (7799 star) (977 fork)batch import
area/uxgood first issuescope/frontendstatus/acceptedtype/bug

Descrizione

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running master-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

when kafka-ui can't access the remote broker, it waits for a long time (this should also have timeout). Meanwhile in the UI you see the loader in the topics page.

In the network tab I can see long request:

http://server/api/clusters/<cluster>/topics?page=1&perPage=25&showInternal=true

At some point it fails with 504, but the loader is still shown on the UI

Expected behavior

Loader should be removed and the error message should be shown

Your installation details

56fa824

Steps to reproduce

  1. make sure kafka ui can't access remote broker.
  2. visit topics page in that cluster

Screenshots

No response

Logs

no logs in the app output

Additional context

No response

Guida contributor

Tech stack
Nessuno
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Basic frontend developmentUnderstanding of HTTP error handling
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75
Direzione di ricerca
Investigate the frontend's API request handling, likely in the Topics page component. Look for where the loader is controlled and add error handling for 504 responses to display an error message instead of keeping the loader. Check if there is an existing error state pattern in the codebase, possibly in the network layer (e.g., axios interceptors) or within the component itself. Reference the commit 56fa824 if available.