project-chip/connectedhomeip

Reduce/remove usage of "all ids/structs/enums" and include exact cluster dependencies

Open

#38.667 aperta il 29 apr 2025

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)C++ (1659 fork)batch import
good first issuestale

Metriche repository

Star
 (6410 star)
Metriche merge PR
 (Merge medio 8g 5h) (375 PR mergiate in 30 g)

Descrizione

We have split cluster specific data into separate files, however we still have usages of global things assumed within various locations. part of it is src/app/clusters which may need treating one by one, however others are the rest of the SDK code.

We should replace https://github.com/project-chip/connectedhomeip/blob/master/zzz_generated/app-common/app-common/zap-generated/cluster-objects.h usage and https://github.com/project-chip/connectedhomeip/blob/master/zzz_generated/app-common/app-common/zap-generated/cluster-enums.h usage with actual cluster/.../....h includes instead

and ensure references for ids include the correct header.

Practical example, WriteClient needs AccessControl::Id https://github.com/project-chip/connectedhomeip/blob/master/src/app/WriteClient.cpp#L273 and it should not assume that this is somehow available through transitive dependencies (it seems to do that now).

Need to figure out how to audit usages of these IDs and clean up references.

Guida contributor