phpmyadmin/phpmyadmin

Navigation panel settings icon issues

Aperta

#18.162 aperta il 26 feb 2023

 (18 commenti) (0 reazioni) (0 assegnatari)PHP (3454 fork)batch import
BugUIaffects/6.0confirmed/6.0good first issuenewbie

Metriche repository

Star
 (6886 stelle)
Metriche merge PR
 (Merge medio 2g 17h) (11 PR mergiate in 30 g)

Descrizione

Describe the bug

There are a few issues with the Navigation panel settings icon from top left.

  • 5.2.2-dev, 6.0.0-dev - On all themes, the icon is still present if Two-factor authentication tab from Settings is selected. (#18308)
  • 5.2.2-dev, 6.0.0-dev - On Bootstrap theme, the icon is present on all tabs from Settings. (#18308)
  • 6.0.0-dev - On all themes, sometimes on Page-related settings modal some dots can be seen (see second video) only if the Settings icon is clicked from home page caused by (list-style-type: disc)
  • 6.0.0-dev - On all themes, the Page-related settings modal is empty while you click on databases from left side, while it shouldn't (see third video)

To fix the remaining issues, the code that creates the modals should be changed, because the modals are created in two places of the page. The right place is at the bottom (see last image)

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master-config/index.php?route=/
  2. From Theme select Bootstrap
  3. Go to Settings
  4. See error

Expected behavior

The icon shouldn't be visible if the user is on Settings page, on all themes.

Screenshots

https://user-images.githubusercontent.com/25424343/221422339-1cbd984d-65b5-4daa-a5fd-f1c142507c60.mp4

https://user-images.githubusercontent.com/25424343/222993867-01c22af3-1e61-437e-be0f-e0b1259ebd58.mp4

https://user-images.githubusercontent.com/25424343/233198095-db98f233-5960-4138-8f74-6465c87cf52f.mp4

two modals

Server configuration

  • phpMyAdmin version: 5.2.2-dev, 6.0.0-dev

Guida contributor