php/doc-en

Min()/Max() example has incorrect information comparing with "hello"

Aperta

#2687 aperta il 15 ago 2023

 (0 commenti) (0 reazioni) (1 assegnatario)XML (882 fork)auto 404
QAgood first issue

Metriche repository

Star
 (596 stelle)
Metriche merge PR
 (Merge medio 99g 23h) (90 PR mergiate in 30 g)

Descrizione

This was missed as part of https://github.com/php/doc-en/commit/8a0ab242e83ec201615c947eaa0e1c5719576c12

But there is a remaining example:

// Here we are comparing -1 < 0, so 'hello' is the highest value
echo max('hello', -1);    // hello

(Ditto for min())

This example is inaccurate as of PHP 8.0, and might make sense to either be split out into its own dedicated example or removed.

@afilina

Guida contributor