papercups-io/papercups

Better phone number filtering for twillio and SMS in integrations page

Open

Aperta il 5 mag 2021

Vedi su GitHub
 (3 commenti) (0 reazioni) (1 assegnatario)Elixir (6032 star) (566 fork)batch import
enhancementgood first issue

Descrizione

Problem Right now if you enter a phone number without the area code or have the wrong formatting in phone number section it will fail silently and not work. We should make sure that there is a country code and that it can work regardless of the text formatting

Solution It should validate that it has a country code and we shouldn't care about formatting

Guida contributor

Tech stack
elixir
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Elixir basicsphone number validation concepts
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Investigate the current phone number input handling in the integrations page, likely in a Phoenix template or LiveView. Look for validation logic in lib/ or web/ directories. Consider using a library like ex phone number or implementing a simple regex for country code presence. Check comments for any existing discussions on preferred approach. The issue specifies ignoring formatting, so focus on stripping non digit characters and ensuring a length that implies a country code (e.g., >= 10 digits).