[MultistepDialog] Allow side navigation to be disabled (e.g. when submitting) · palantir/blueprint#4872

2021-08-20T23:15:32.000Z

#### Environment - __Package version(s)__: @blueprintjs/core@3.48.0 #### Feature Request 1. Add a `disabled` prop to ` ` that would allow the side navigation to be disabled (e.g when the dialog is being submitted) 1. Perhaps if specified `true` (and ignored as `false | undefined`), it could also combine & override any individual `disabled` props for all the other steps' `nextButtonProps` and `backButtonProps`? (You can see in my Code Sandbox example, I am passing `|| submitting` through to most of them) #### Code Sandbox https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d #### Steps to reproduce (Using the example in the Code Sandbox) 1. Advance through each step of the ` ` to the end. 2. See how each step must be "valid" before you can progress. 3. On the last step, click the "Submit" button to trigger a fake submit state. 4. ❌ See that you can still navigate around between past steps via the side navigation whilst the form submit is ongoing.

(3 commenti) (0 reazioni) (0 assegnatari)TypeScript (2167 fork)batch import

P2Package: coreType: feature requesthelp wanted

Metriche repository

Star: (20.263 star)
Metriche merge PR: (Merge medio 43g 10h) (27 PR mergiate in 30 g)

Descrizione

Environment

Package version(s): @blueprintjs/core@3.48.0

Feature Request

Add a disabled prop to <MultistepDialog> that would allow the side navigation to be disabled (e.g when the dialog is being submitted)
Perhaps if specified true (and ignored as false | undefined), it could also combine & override any individual disabled props for all the other steps' nextButtonProps and backButtonProps? (You can see in my Code Sandbox example, I am passing || submitting through to most of them)

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d

Steps to reproduce

(Using the example in the Code Sandbox)

Advance through each step of the <MultistepDialog> to the end.
See how each step must be "valid" before you can progress.
On the last step, click the "Submit" button to trigger a fake submit state.
❌ See that you can still navigate around between past steps via the side navigation whilst the form submit is ongoing.

Guida contributor

Direzione di ricerca: Esamina il componente MultistepDialog per comprendere la struttura di navigazione e delle proprietà, quindi aggiungi una prop `disabled` che disabilita la navigazione laterale e opzionalmente sovrascrive le prop dei singoli pulsanti dei passaggi.
Tech stack: typescriptreact
Dominio: frontend
Tipo issue: Funzionalità
Difficoltà: 2
Tempo stimato: 1-3 ore
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: React
Adatta ai principianti: 75