palantir/blueprint

Table header cell - Clicking on an an element also selects the column.

Open

#3685 aperta il 30 lug 2019

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)TypeScript (2167 fork)batch import
Domain: APIPackage: tablehelp wanted

Metriche repository

Star
 (20.263 star)
Metriche merge PR
 (Merge medio 24g 18h) (17 PR mergiate in 30 g)

Descrizione

Environment

  • Package version(s): blueprint-table 3.4.1
  • Browser and OS versions: Chrome 75.0.3770.142

Steps to reproduce

  1. Have a table with buttons or a drag handle in the column header cells, and selection enabled.
  2. Click on the button or handle.

Actual behavior

The column is selected, since selection is enabled.

selection

This is particularly annoying when selection causes other things on the page to render, potentially moving the table and then no longer executing the intended click action.

selection-move

Expected behavior

Clicking on an element in the header that has interaction ignores selection.

Possible solution

I noticed that header cells have an ignoredSelectors prop, which does exactly what is needed here, but isn't exposed. Would be nice if this was exposed, so we can add css selectors that could be ignored.

I also noticed the isHeaderMouseTarget static method in the ColumnHeaderCell, but then we need some sort of callback on header click to know what the target is.

Guida contributor