oppia/oppia

[BUG]: TODO(bhenning): Split the validation tests into separate unit tests.

Open

#20.377 aperta il 29 mag 2024

Vedi su GitHub
 (38 commenti) (0 reazioni) (1 assegnatario)Python (3534 fork)batch import
Impact: Low -- ONLY DO IF GOOD FIRST ISSUEWork: Lowbugfrontendgood first issue

Metriche repository

Star
 (5292 star)
Metriche merge PR
 (Merge medio 20g 19h) (71 PR mergiate in 30 g)

Descrizione

Describe the bug

The validation tests below should be split into separate unit tests. Also, all validation errors should be covered in the tests. Split the validation tests in ‘test_validation’ and cover all errors. The current ‘test_validation’ function contains multiple validation checks for explorations. This makes the test logic complex and difficult to maintain. Not all potential validation errors might be covered in this single test.

URL of the page where the issue is observed.

core/domain/exp_domain_test.py

Steps To Reproduce

Open the core/domain/exp_domain_test.py

Expected Behavior

The validation tests should be split into separate unit tests, also covering all test cases.

Screenshots/Videos

No response

What device are you using?

Desktop

Operating System

Linux

What browsers are you seeing the problem on?

No response

Browser version

No response

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

Guida contributor