openstreetmap/iD

"Follow" may create a self-intersecting area

Aperta

#9154 aperta il 9 giu 2022

 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (1449 fork)github user discovery
bughelp wantedoperation

Metriche repository

Star
 (3818 stelle)
Metriche merge PR
 (Merge medio 29g 14h) (82 PR mergiate in 30 g)

Descrizione

URL

No response

How to reproduce the issue?

  1. Create a simple area, say a triangular one (the top one on the screenshot)
  2. Start creating another area nearby; snap its 2nd and 3rd vertices to the first area
  3. Hit [F] several times to "follow" the first area, i.e. create new common vertices. They go around and around the first area, effectively doing a "plastic wrap".
  4. Hit [Esc] to finish the second area. It succeeds.

Now, you've just created an odd, self-intersecting area that can be tagged and committed without a warning.

iD should detect this form of self-intersecting area and prevent executing step (3) or, at minimum, step (4) . Actually, it does complain if I want to complete the area against the topmost vertex, but not in the situation on the screenshot.

Screenshot(s) or anything else?

Selfintersecting

Which iD Editor versions do you see the issue on?

Released version at openstreetmap.org/edit

Which browsers are you seeing this problem on?

No response

Guida contributor