open-telemetry/opentelemetry-php

[Feature Request] Integrating Laravel with sqlcommenter

Aperta

#1346 aperta il 12 lug 2024

 (2 commenti) (0 reazioni) (0 assegnatari)PHP (224 fork)auto 404
help wantedinstrumentation

Metriche repository

Star
 (894 stelle)
Metriche merge PR
 (Merge medio 5g 5h) (5 PR mergiate in 30 g)

Descrizione

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue in opentelemetry-specification first.

This feature is implemented in python, django. And in the past there was a library for Laravel. https://github.com/open-telemetry/opentelemetry-sqlcommenter/blob/main/docs/python/django/README.md/#installation https://github.com/google/sqlcommenter/tree/master/php/sqlcommenter-php/packages/sqlcommenter-laravel

Is your feature request related to a problem?

It would be useful to add comments to the SQL. https://github.com/open-telemetry/opentelemetry-php/issues/1345

Describe the solution you'd like

Integrating Laravel with sqlcommenter.

Describe alternatives you've considered

I'm currently forking and using the google repository. https://github.com/moeyashi/sqlcommenter/tree/update-opentelemetry

Additional context

It's probably not something we'll implement right away.

I think we'll align our approach with other languages ​​through discussions on https://github.com/open-telemetry/opentelemetry-specification/issues/3560 and https://github.com/open-telemetry/opentelemetry-sqlcommenter/issues/5.

Guida contributor