onivim/oni

Thoughts on the new global search

Open

#1553 aperta il 14 feb 2018

Vedi su GitHub
 (3 commenti) (3 reazioni) (0 assegnatari)TypeScript (336 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (11.389 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Hi all, I just updated to 0.3.0 which has the new "VS Code" style sidebar with global search and I wanted to give my input about an alternative implementation (I sincerely hope that no one takes any offence to this).

I personally prefer the approach to global search that emacs-helm, atom-narrow and unite.vim take. The advantages of this style of approach include:

  • You get a consistent UI for narrowing lists of different types of data sources instead of a specific UI for just global line-wise search (i.e. ripgrep). For example, with the tools listed above you can use to same UI for local symbol search, global symbol search, global line-wise search, local line-wise search, local folds and more
  • It can be made to be extensible (just like how you can add your own custom sources with unite.vim)
  • Quicker to visually parse because the input text field is co-located with the results
  • This last point is quite opinionated, but I also feel that this approach is more "vim-like"

Looking forward to hearing your thoughts on this :)

Guida contributor