nodejs/undici

Unprecise error message on fetch() to an endpoint with a certificate which was signed by an "unkown" CA

Chiusa

#2199 aperta il 28 lug 2023

Vedi su GitHubGuida contributor
 (5 commenti) (0 reazioni) (0 assegnatari)JavaScript (444 fork)batch import
enhancementgood first issue

Metriche repository

Star
 (5319 stelle)
Metriche merge PR
 (Merge medio 2g 10h) (82 PR mergiate in 30 g)

Descrizione

Bug Description

There is a unprecise error message ("fetch failed") on fetch() to an endpoint with a certificate which was signed by an "unkown" CA. If its an custom or internal CA, the fetch() will fail, that seems correct, but the error message ist absolut unprecise. It is therefore very difficult to find the cause.

Reproducible By

fetch() to an enpoint with a certificate which was signed by an "unkown" CA.

An "unkown" CA seems to be an CA which not exist in the default search path for CAs of node. By default node seem to use CA-certificates baked in the build.

Expected Behavior

A useful error message is shown.

Logs & Screenshots

TypeError: fetch failed at Object.fetch (node:internal/deps/undici/undici:11576:11) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) ...

Environment

Ubuntu 22.04 Node v18.17.0

Guida contributor

Direzione di ricerca
Locate the source of the 'fetch failed' error message in undici's fetch implementation (likely in lib/fetch or node:internal/deps/undici/undici). Investigate how certificate errors are caught and currently emit generic messages. The fix should propagate the underlying TLS/certificate error to provide a clear error message indicating the CA issue.
Tech stack
javascriptnodejs
Dominio
backenddeveloper experience
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Richiede indagine
Prerequisiti
basic knowledge of Node.jsfamiliarity with undici HTTP client
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60