nodejs/node

test_runner: do not read from `process.argv` and `process.cwd()` in run()

Open

Aperta il 16 lug 2024

Vedi su GitHub
 (13 commenti) (5 reazioni) (0 assegnatari)JavaScript (117.218 star) (35.535 fork)batch import
good first issuetest_runner

Descrizione

Currently the codebase for https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/test_runner/runner.js#L472 accesses some poperties of process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/main/test_runner.js#L68 and pass it down to run() as options.

Guida contributor

Tech stack
javascriptnodejs
Dominio
backendtesting
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
understanding of Node.js internalsknowledge of process.argv and process.cwd()familiarity with test runner module
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
The issue requires moving the capture of process.argv and process.cwd() from runner.js to test runner.js and passing them as options to run(). Examine the code in lib/internal/test runner/runner.js around line 472 and lib/internal/main/test runner.js around line 68 to understand current usage. Ensure that all dependencies on process properties are relocated and passed as parameters. No linked PRs or additional context in comments.