nodejs/node

Re-enable test-ubsan.yml

Open

Aperta il 29 apr 2024

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (117.218 star) (35.535 fork)batch import
help wantedmetastale

Descrizione

During the latest Node.js major release (https://github.com/nodejs/node/pull/52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (https://github.com/nodejs/node/pull/52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

  • It seems clang provides a better output and some docs we could use in the suppressions file.
    • Changing from g++ to clang for UBSAN will require changing all the suppression file

Guida contributor

Tech stack
javascriptcpp
Dominio
ci cdtesting
Tipo issue
test
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
4
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Node.js build systemUBSANC++ compiler basicsCI configuration
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30
Direzione di ricerca
Examine the disabled test ubsan.yml and the suppression files referenced in the insights. Investigate the V8 update that caused failures (PR #52560) and understand why g++ was used. Look into switching to clang for better output and updating the suppression file accordingly. Consult the linked PR #52505 for context.